specs-go: add label to config.go #460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wking
reviewed
Nov 17, 2016
| @@ -45,6 +45,9 @@ type ImageConfig struct { | |||
|
|
|||
| // WorkingDir sets the current working directory of the entrypoint process in the container. | |||
| WorkingDir string `json:"WorkingDir,omitempty"` | |||
|
|
|||
| // Labels contains arbitrary metadata for the container. | |||
| Labels map[string]struct{} `json:"labels,omitempty"` | |||
There was a problem hiding this comment.
The spec calls for map[string]string.
And we'll need JSON Schema work too, although that doesn't have to happen in this PR.
There was a problem hiding this comment.
@wking yes, it's map[string]string.
And we'll need JSON Schema work too, although that doesn't have to happen in this PR.
working on it
coolljt0725
force-pushed
the
label
branch
4 times, most recently
from
d139900 to
a43effe
Compare
|
@coolljt0725 rebase please? |
Signed-off-by: Lei Jitang <leijitang@huawei.com>
Signed-off-by: Lei Jitang <leijitang@huawei.com>
|
@vbatts rebased |
|
LGTM |
1 similar comment
|
LGTM |
cyphar
added a commit
to opencontainers/umoci
that referenced
this pull request
Dec 10, 2016
In order to fix a slight goof on the side of upstream (image-spec) we have to add a patch that includes opencontainers/image-spec#460 (which was _meant_ to be in v1.0.0-rc3 because the relevant spec change was included). Signed-off-by: Aleksa Sarai <asarai@suse.com>
cyphar
added a commit
to opencontainers/umoci
that referenced
this pull request
Dec 10, 2016
In order to fix a slight goof on the side of upstream (image-spec) we have to add a patch that includes opencontainers/image-spec#460 (which was _meant_ to be in v1.0.0-rc3 because the relevant spec change was included). Signed-off-by: Aleksa Sarai <asarai@suse.com>
cyphar
added a commit
to opencontainers/umoci
that referenced
this pull request
Dec 10, 2016
In order to fix a slight goof on the side of upstream (image-spec) we have to add a patch that includes opencontainers/image-spec#460 (which was _meant_ to be in v1.0.0-rc3 because the relevant spec change was included). Signed-off-by: Aleksa Sarai <asarai@suse.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Lei Jitang leijitang@huawei.com
follow up #371