Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

specs-go/v1: use correct field type for diff ids #617

Merged
merged 1 commit into from
Mar 22, 2017

Conversation

stevvooe
Copy link
Contributor

Signed-off-by: Stephen J Day stephen.day@docker.com

@stevvooe stevvooe added this to the v1.0.0-rc6 milestone Mar 17, 2017
@xiekeyang
Copy link
Contributor

It seems good to me. CI is failed because its deadline value inappropriate. I present the fix patch in #619

Signed-off-by: Stephen J Day <stephen.day@docker.com>
@stevvooe stevvooe force-pushed the correct-field-type branch from 102f17f to d858089 Compare March 20, 2017 19:57
@stevvooe
Copy link
Contributor Author

@xiekeyang Fixed.

@xiekeyang
Copy link
Contributor

LGTM

@jonboulle
Copy link
Contributor

jonboulle commented Mar 21, 2017

lgtm

Approved with PullApprove

@jbouzane
Copy link

LGTM

@stevvooe stevvooe merged commit bfc49af into opencontainers:master Mar 22, 2017
@vbatts vbatts mentioned this pull request May 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants