Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

descriptor: Replace "supported" with "registered" #668

Merged
merged 1 commit into from
May 12, 2017

Conversation

wking
Copy link
Contributor

@wking wking commented May 10, 2017

Avoid adding a second word meaning the same thing (spun off from here). I've consolidated around “registered” because it matches the existing “Registered algorithms” header.

Also some copy-edits for the sentences I've touched:

  • “alpha numeric” -> “alphanumerics” (matching Wikipedia).
  • “paramterize” -> “parameterize”
  • “future extension of digest support” -> “extensions”, because folks may be taking advantage of the extended grammar now, without waiting for the image-spec to take advantage of the extended grammar.

@wking
Copy link
Contributor Author

wking commented May 10, 2017

This will conflict with #666. I'm happy to rebase after #666 lands.

@vbatts
Copy link
Member

vbatts commented May 12, 2017

LGTM but pls2rebase

Approved with PullApprove

@wking wking force-pushed the supported-to-registered branch from 723ddd8 to 0eee504 Compare May 12, 2017 18:43
@wking
Copy link
Contributor Author

wking commented May 12, 2017

Rebased around #666 with 723ddd83497ca3.

@wking wking force-pushed the supported-to-registered branch from 0eee504 to 3497ca3 Compare May 12, 2017 18:44
Avoid adding a second word meaning the same thing.  I've consolidated
around "registered" because it matches the existing "Registered
algorithms" header.

Also some copy-edits for the sentences I've touched:

* "alpha numeric" -> "alphanumerics" (matching [1]).
* "paramterize" -> "parameterize
* "future extension of digest support" -> "extensions", because folks
  may be taking advantage of the extended grammar *now*, without
  waiting for the image-spec to take advantage of the extended
  grammar.

[1]: https://en.wikipedia.org/wiki/Alphanumeric

Signed-off-by: W. Trevor King <wking@tremily.us>
@stevvooe
Copy link
Contributor

stevvooe commented May 12, 2017

LGTM

Approved with PullApprove

1 similar comment
@vbatts
Copy link
Member

vbatts commented May 12, 2017

LGTM

Approved with PullApprove

@vbatts vbatts merged commit b25e32a into opencontainers:master May 12, 2017
@vbatts vbatts mentioned this pull request May 19, 2017
@wking wking deleted the supported-to-registered branch September 18, 2017 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants