Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename refers field to subject #950

Merged
merged 1 commit into from
Sep 15, 2022

Conversation

sajayantony
Copy link
Member

Addresses the renaming of refers --> subject for #940

Signed-off-by: Sajay Antony sajaya@microsoft.com

Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see suggested edit

specs-go/v1/artifact.go Outdated Show resolved Hide resolved
specs-go/v1/manifest.go Outdated Show resolved Hide resolved
Copy link
Contributor

@michaelb990 michaelb990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IANAM but LGTM 👍

Co-authored-by: Mike Brown <brownwm@us.ibm.com>
Signed-off-by: Sajay Antony <sajaya@microsoft.com>
@sajayantony
Copy link
Member Author

Thanks @sudo-bmitch for tooling fixes and @mikebrow for the working updates.

Copy link
Contributor

@sudo-bmitch sudo-bmitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We need a similar update to distribution-spec.

sajayantony added a commit to sajayantony/distribution-spec that referenced this pull request Sep 13, 2022
Fixes correspond to the the image spec changes
- opencontainers/image-spec#950

Signed-off-by: Sajay Antony <sajaya@microsoft.com>
sajayantony added a commit to sajayantony/distribution-spec that referenced this pull request Sep 13, 2022
Fixes correspond to the the image spec changes
- opencontainers/image-spec#950

Signed-off-by: Sajay Antony <sajaya@microsoft.com>
Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sajayantony added a commit to sajayantony/distribution-spec that referenced this pull request Sep 14, 2022
Fixes correspond to the the image spec changes
- opencontainers/image-spec#950

Signed-off-by: Sajay Antony <sajaya@microsoft.com>
@sudo-bmitch sudo-bmitch added this to the v1.1 milestone Sep 15, 2022
Copy link
Contributor

@stevvooe stevvooe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Assuming this is safe. Target might be better, since subject usually refers to a set of users in auth systems, but this looks fine.

@sajayantony sajayantony merged commit a7ac485 into opencontainers:main Sep 15, 2022
@sajayantony sajayantony deleted the rename-to-subject branch September 15, 2022 17:37
@sajayantony sajayantony mentioned this pull request Sep 26, 2022
sudo-bmitch pushed a commit to sudo-bmitch/distribution-spec that referenced this pull request Aug 18, 2023
Fixes correspond to the the image spec changes
- opencontainers/image-spec#950

Signed-off-by: Sajay Antony <sajaya@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants