-
Notifications
You must be signed in to change notification settings - Fork 652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename refers field to subject #950
Rename refers field to subject #950
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see suggested edit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IANAM but LGTM 👍
Co-authored-by: Mike Brown <brownwm@us.ibm.com> Signed-off-by: Sajay Antony <sajaya@microsoft.com>
70a8571
to
8940c90
Compare
8940c90
to
a3eba63
Compare
Thanks @sudo-bmitch for tooling fixes and @mikebrow for the working updates. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. We need a similar update to distribution-spec.
Fixes correspond to the the image spec changes - opencontainers/image-spec#950 Signed-off-by: Sajay Antony <sajaya@microsoft.com>
Fixes correspond to the the image spec changes - opencontainers/image-spec#950 Signed-off-by: Sajay Antony <sajaya@microsoft.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes correspond to the the image spec changes - opencontainers/image-spec#950 Signed-off-by: Sajay Antony <sajaya@microsoft.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Assuming this is safe. Target
might be better, since subject
usually refers to a set of users in auth systems, but this looks fine.
Fixes correspond to the the image spec changes - opencontainers/image-spec#950 Signed-off-by: Sajay Antony <sajaya@microsoft.com>
Addresses the renaming of
refers
-->subject
for #940Signed-off-by: Sajay Antony sajaya@microsoft.com