docs: Added artifact.md to docs #957
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sajayantony
requested review from
cyphar,
jonboulle,
jonjohnsonjr,
stevvooe,
sudo-bmitch and
vbatts
as code owners
sajayantony
force-pushed
the
fix-docs
branch
from
a969a02 to
6a68100
Compare
sudo-bmitch
requested changes
Sep 24, 2022
Contributor
sudo-bmitch
left a comment
sudo-bmitch
left a comment
There was a problem hiding this comment.
Thanks for running with this one. We also need to add a reference to artifact.md in the "Table of Contents" at the top of spec.md.
Contributor
|
The more I think about the subject field in the graphic, and anything with a descriptor to a manifest, the more I want a general manifest and blob in the graphic, and have pointers go to those general types. I'll do some digging into graphviz and see if there's a better way to draw it. In the mean time, if another wants to approve this, I'll update my review and follow up with a separate PR. |
sajayantony
force-pushed
the
fix-docs
branch
from
a4ce399 to
6b7c605
Compare
Added artifact.md and updated the media-types diagram dot and png. Co-authored-by: Brandon Mitchell <git@bmitch.net> Signed-off-by: Sajay Antony <sajaya@microsoft.com>
sajayantony
force-pushed
the
fix-docs
branch
from
6b7c605 to
0a97fe7
Compare
sudo-bmitch
approved these changes
Sep 27, 2022
Contributor
sudo-bmitch
left a comment
sudo-bmitch
left a comment
There was a problem hiding this comment.
LGTM. There's still some work to do on the graphic, but this gets us in a better place.
jonjohnsonjr
approved these changes
Oct 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added artifact.md and updated the media-types diagram dot and png.
Signed-off-by: Sajay Antony sajaya@microsoft.com