Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

image_test.go: Improve the test content #100

Merged
merged 1 commit into from
Jan 22, 2017

Conversation

zhouhao3
Copy link

Signed-off-by: zhouhao zhouhao@cn.fujitsu.com

Signed-off-by: zhouhao <zhouhao@cn.fujitsu.com>
@zhouhao3
Copy link
Author

zhouhao3 commented Jan 16, 2017

@xiekeyang @stevvooe @coolljt0725 PTAL

@coolljt0725
Copy link
Member

@q384566678 we need to bump the image-spec first before we have this changes, because Labels is not in the image-spec which the image-tool currently used.

@zhouhao3
Copy link
Author

@coolljt0725 I do not quite understand the meaning of bump, can you please explain to me? thanks.

@coolljt0725
Copy link
Member

@q384566678 #69 is an example of bump

@zhouhao3
Copy link
Author

@coolljt0725 Since #102 has been merged, the bump is complete.

@coolljt0725
Copy link
Member

coolljt0725 commented Jan 22, 2017

LGTM

Approved with PullApprove

1 similar comment
@xiekeyang
Copy link
Contributor

xiekeyang commented Jan 22, 2017

LGTM

Approved with PullApprove

@xiekeyang xiekeyang merged commit 23e1dd1 into opencontainers:master Jan 22, 2017
@zhouhao3 zhouhao3 deleted the config_test branch February 1, 2017 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants