Skip to content

Commit

Permalink
libct: add TODO about os.ErrProcessDone
Browse files Browse the repository at this point in the history
This is a new variable added by go 1.16 so we'll have to wait
until 1.16 is minimally supported version, thus TODO for now.

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
  • Loading branch information
kolyshkin committed Jan 6, 2021
1 parent d7df301 commit 72f4638
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions libcontainer/container_linux.go
Original file line number Diff line number Diff line change
Expand Up @@ -2075,6 +2075,9 @@ func ignoreTerminateErrors(err error) error {
if errors.As(err, &exitErr) {
return nil
}
// TODO: use errors.Is(err, os.ErrProcessDone) here and
// remove "process already finished" string comparison below
// once go 1.16 is minimally supported version.

s := err.Error()
if strings.Contains(s, "process already finished") ||
Expand Down

0 comments on commit 72f4638

Please sign in to comment.