Unable to update kmem limit only #1347
Comments
hqhq
added a commit
to hqhq/runc
that referenced
this issue
Feb 25, 2017
Fixes: opencontainers#1347 Fixes: opencontainers#1083 The root cause of opencontainers#1083 is because we're joining an existed cgroup whose kmem accouting is not initialized, and it has child cgroup or tasks in it. Fix it by checking if the cgroup is first time created, and we should enable kmem accouting if the cgroup is craeted by libcontainer with or without kmem limit configed. Otherwise we'll get issue like opencontainers#1347 Signed-off-by: Qiang Huang <h.huangqiang@huawei.com>
|
Yes, it fixed the problem. |
This was referenced Apr 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Due to commit 11222ee , it is not possible update item limit if not specified a default value in the config in the first place.
# runc update --kernel-memory 50331648 rootfailed to set memory.kmem.limit_in_bytes, because either tasks have already joined this cgroup or it has children
However, it is fine to update other memory limits even if did not specify default values in the config.json.
# runc update --memory-reservation 50331648 root# runc update --memory 50331648 root# runc update --memory-swap 50331648 root@crosbymichael PTAL
The text was updated successfully, but these errors were encountered: