Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass id to all runc commands #532

Closed
crosbymichael opened this issue Feb 4, 2016 · 2 comments
Closed

Pass id to all runc commands #532

crosbymichael opened this issue Feb 4, 2016 · 2 comments
Milestone
0.0.8

Comments

@crosbymichael
Copy link
Member

Remove the --id flag and start passing

runc start redis

where redis is the container's id
@crosbymichael crosbymichael added this to the 0.0.8 milestone Feb 4, 2016
@mikebrow
Copy link
Member

mikebrow commented Feb 5, 2016

Did you start this one? I can pop out a PR for this if not. I was going to do it after bringing mrunal's merged config.json and runtime.json into runc. Cheers.

@crosbymichael
Copy link
Member Author

no i have not

crosbymichael added a commit to crosbymichael/runc that referenced this issue Feb 8, 2016
@crosbymichael
Require containerd id as arg 1
8f2bde7 
Closes opencontainers#532

This requires the container id to always be passed to all runc commands
as arg one on the cli.  This was the result of the last OCI meeting and
how operations work with the spec.

Signed-off-by: Michael Crosby <crosbymichael@gmail.com>
@crosbymichael crosbymichael mentioned this issue Feb 8, 2016
Merged
crosbymichael added a commit to crosbymichael/runc that referenced this issue Feb 8, 2016
@crosbymichael
Require containerd id as arg 1
f2cbeb9 
Closes opencontainers#532

This requires the container id to always be passed to all runc commands
as arg one on the cli.  This was the result of the last OCI meeting and
how operations work with the spec.

Signed-off-by: Michael Crosby <crosbymichael@gmail.com>
crosbymichael added a commit to crosbymichael/runc that referenced this issue Feb 9, 2016
@crosbymichael
Require containerd id as arg 1
4740061 
Closes opencontainers#532

This requires the container id to always be passed to all runc commands
as arg one on the cli.  This was the result of the last OCI meeting and
how operations work with the spec.

Signed-off-by: Michael Crosby <crosbymichael@gmail.com>
crosbymichael added a commit to crosbymichael/runc that referenced this issue Feb 9, 2016
@crosbymichael
Require containerd id as arg 1
43cee51 
Closes opencontainers#532

This requires the container id to always be passed to all runc commands
as arg one on the cli.  This was the result of the last OCI meeting and
how operations work with the spec.

Signed-off-by: Michael Crosby <crosbymichael@gmail.com>
crosbymichael added a commit to crosbymichael/runc that referenced this issue Feb 9, 2016
@crosbymichael
Require containerd id as arg 1
a7278ca 
Closes opencontainers#532

This requires the container id to always be passed to all runc commands
as arg one on the cli.  This was the result of the last OCI meeting and
how operations work with the spec.

Signed-off-by: Michael Crosby <crosbymichael@gmail.com>
@wking wking mentioned this issue Jul 10, 2016
Closed
@hqhq hqhq mentioned this issue Aug 25, 2017
Closed
stefanberger pushed a commit to stefanberger/runc that referenced this issue Sep 8, 2017
@crosbymichael
Merge pull request opencontainers#532 from wking/tk/restore-hook-life…
7da699d 
…cycle

Restore hook language removed by create/start split
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.0.8
Development

No branches or pull requests
2 participants
@crosbymichael @mikebrow