tests: allow to load kernel modules from a test container #1750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@avagin this fixed my issue, now |
|
LGTM |
cyphar
reviewed
Mar 1, 2018
| @@ -65,13 +65,13 @@ localtest: | |||
| make localunittest localintegration localrootlessintegration | |||
|
|
|||
| unittest: runcimage | |||
| docker run -e TESTFLAGS -t --privileged --rm -v $(CURDIR):/go/src/$(PROJECT) $(RUNC_IMAGE) make localunittest | |||
There was a problem hiding this comment.
Should /lib/modules be read-only? I'm a little concerned about making it read-write (in case something breaks and we overwrite some critical modules).
There was a problem hiding this comment.
You are right. Will fix.
CRIU needs to load a few modules to checkpoint/resume containers. opencontainers#1745 Signed-off-by: Andrei Vagin <avagin@virtuozzo.com>
|
LGTM. Thanks @avagin. |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CRIU needs to load a few modules to checkpoint/resume containers.
#1745
Signed-off-by: Andrei Vagin avagin@virtuozzo.com