Fix race in runc exec #1812
Merged
Fix race in runc exec #1812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@crosbymichael @cyphar @dqminh PTAL |
|
This is triggered by healthchecks in Dockerfile and kubernetes readiness/liveness probes. Credit to Ulrich Obergfell for pinpointing this issue. |
mrunalp
force-pushed
the
fix_exec_race
branch
3 times, most recently
from
c692f2c to
ee36781
Compare
There is a race in runc exec when the init process stops just before the check for the container status. It is then wrongly assumed that we are trying to start an init process instead of an exec process. This commit add an Init field to libcontainer Process to distinguish between init and exec processes to prevent this race. Signed-off-by: Mrunal Patel <mrunalp@gmail.com>
dqminh
approved these changes
Jun 2, 2018
| @@ -140,6 +140,7 @@ func execProcess(context *cli.Context) (int, error) { | |||
| detach: detach, | |||
| pidFile: context.String("pid-file"), | |||
| action: CT_ACT_RUN, | |||
| init: false, | |||
|
LGTM |
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a race in runc exec when the init process stops just before
the check for the container status. It is then wrongly assumed that
we are trying to start an init process instead of an exec process.
Signed-off-by: Mrunal Patel mrunalp@gmail.com