Add osusergo flag to static build #1836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should fix the following (very legitimate) warnings on static build: > /tmp/go-link-818454663/000019.o: In function `mygetgrouplist': > /usr/lib/go-1.10/src/os/user/getgrouplist_unix.go:15: warning: Using > 'getgrouplist' in statically linked applications requires at runtime the > shared libraries from the glibc version used for linking > > /tmp/go-link-818454663/000018.o: In function `mygetgrgid_r': > /usr/lib/go-1.10/src/os/user/cgo_lookup_unix.go:38: warning: Using > 'getgrgid_r' in statically linked applications requires at runtime the > shared libraries from the glibc version used for linking > > ... as well as segfaults in the resulting binary. For more details, check golang/go#23265 Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
|
LGTM |
|
Oh awesome. I didn't know that Go's stdlib actually had a way of disabling the LGTM. |
cyphar
added a commit
that referenced
this pull request
Jul 5, 2018
Add osusergo flag to static build LGTMs: @crosbymichael @cyphar Closes #1836
|
Yes; it's new in Go 1.11 @kolyshkin contributed that change (golang/go@62f0127) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the following (very legitimate) warnings on static build:
as well as segfaults in the resulting binary.
For more details, check golang/go#23265