-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libcontainer/intelrdt: rm init() from intelrdt.go #2678
Conversation
This is the follow-up PR for #2643 : See details in #2643 (comment). Please help review the third commit only, the first and second commits are dependencies. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
e8bb13a
to
d026080
Compare
Rebased for dependency #2677 has been merged. |
LGTM |
@crosbymichael @AkihiroSuda |
d026080
to
7cafdeb
Compare
@crosbymichael @AkihiroSuda @kolyshkin @Creatone |
d012059
to
1a74585
Compare
Travis-CI always fails on cases "Go: 1.15.x", "Go: 1.14.x", and "Go: tip" with the same error: Looks like something wrong with Travis-CI itself? |
8ac1042
to
481ce35
Compare
The Travis-CI system issue seems to be fixed already. @crosbymichael @AkihiroSuda @kolyshkin @Creatone |
481ce35
to
c2fc85e
Compare
c2fc85e
to
8eeba7d
Compare
@crosbymichael @AkihiroSuda @kolyshkin Could you help re-approve at your convenience? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On a second thought, I think it needs to be changed to not require user call Init explicitly (see details above).
@kolyshkin Thank you very much for code review and good suggestions. I will make change to prevent calling Init() explicitly by outside caller. |
0634d26
to
325a74d
Compare
@kolyshkin Change log:
|
Use sync.Once to init Intel RDT when needed for a small speedup to operations which do not require Intel RDT. Simplify IntelRdtManager initialization in LinuxFactory. Signed-off-by: Xiaochen Shen <xiaochen.shen@intel.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, and thanks for working on this.
@AkihiroSuda PTAL
Use sync.Once to init Intel RDT when needed for a small speedup to
operations which do not require Intel RDT.
Simplify IntelRdtManager initialization in LinuxFactory.
Signed-off-by: Xiaochen Shen xiaochen.shen@intel.com