Retry when write file busy #2810
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wzshiming
force-pushed
the
fix/write-file-busy
branch
from
fc088a1 to
802119e
Compare
Signed-off-by: Shiming Zhang <wzshiming@foxmail.com>
wzshiming
force-pushed
the
fix/write-file-busy
branch
from
802119e to
7072384
Compare
kolyshkin
reviewed
Feb 19, 2021
| @@ -42,7 +42,7 @@ func ReadFile(dir, file string) (string, error) { | |||
| func retryingWriteFile(fd *os.File, data string) error { | |||
| for { | |||
| _, err := fd.Write([]byte(data)) | |||
| if errors.Is(err, unix.EINTR) { | |||
| if errors.Is(err, unix.EINTR) || errors.Is(err, unix.EBUSY) { | |||
| logrus.Infof("interrupted while writing %s to %s", data, fd.Name()) | |||
There was a problem hiding this comment.
The log message is obviously not right for EBUSY case.
|
@wzshiming thank you for your PR. As discussed in #2736, we don't think retrying on EBUSY is the adequate solution. This is a configuration error (memory limit is too tight), and the best we can do in such a case is provide a better error message (looking into that). Are you able to reproduce the issue with adequate memory limit set? |
|
In addition, |
|
I am working on a more specific fix (to clarify the error message and provide more diagnostics in case of error -- WIP is in #2812) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2736