Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libcontainer/intelrdt: support ClosID parameter #2920

Merged
merged 5 commits into from
Aug 31, 2021

Commits on Aug 9, 2021

  1. libcontainer/intelrdt: refactor clos path handling

    Simplify the code and make path a property of the container (via
    intelRdtManager).
    
    Signed-off-by: Markus Lehtonen <markus.lehtonen@intel.com>
    marquiz committed Aug 9, 2021
    Configuration menu
    Copy the full SHA
    7296dc1 View commit details
    Browse the repository at this point in the history
  2. libcontainer/intelrdt: support ClosID parameter

    Handle ClosID parameter of IntelRdt. Makes it possible to use
    pre-configured classes/ClosIDs and avoid running out of available IDs
    which easily happens with per-container classes.
    
    Remove validator checks for empty L3CacheSchema and MemBwSchema fields
    in order to be able to leave them empty, and only specify ClosID for
    a pre-configured class.
    
    Signed-off-by: Markus Lehtonen <markus.lehtonen@intel.com>
    marquiz committed Aug 9, 2021
    Configuration menu
    Copy the full SHA
    17e3b41 View commit details
    Browse the repository at this point in the history
  3. libcontainer/intelrdt: verify ClosID existence

    Check that the ClosID directory pre-exists if no L3 or MB schema has
    been specified. Conform with the following line from runtime-spec
    (config-linux):
    
      If closID is set, and neither of l3CacheSchema and memBwSchema are
      set, runtime MUST check if corresponding pre-configured directory
      closID is present in mounted resctrl. If such pre-configured directory
      closID exists, runtime MUST assign container to this closID and
      generate an error if directory does not exist.
    
    Add a TODO note for verifying existing schemata against L3/MB
    parameters.
    
    Signed-off-by: Markus Lehtonen <markus.lehtonen@intel.com>
    marquiz committed Aug 9, 2021
    Configuration menu
    Copy the full SHA
    79d292b View commit details
    Browse the repository at this point in the history
  4. libcontainer/intelrdt: always run unit tests

    Run unit tests irrespective of the underlying system configuration, i.e.
    even if RDT has not been enabled or is not supported. The tests do not
    depend on real kernel interfaces.
    
    Signed-off-by: Markus Lehtonen <markus.lehtonen@intel.com>
    marquiz committed Aug 9, 2021
    Configuration menu
    Copy the full SHA
    1b4c30f View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2021

  1. libcontainer/intelrdt: update code comments

    Use the term "clos group" instead of "container_id group" as the group
    that a container belongs to is not necessarily tied to its container id.
    
    Signed-off-by: Markus Lehtonen <markus.lehtonen@intel.com>
    marquiz committed Aug 20, 2021
    Configuration menu
    Copy the full SHA
    9393700 View commit details
    Browse the repository at this point in the history