Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VERSION: release 1.0.0-rc94 #2927

Closed
wants to merge 2 commits into from
Closed

VERSION: release 1.0.0-rc94 #2927

wants to merge 2 commits into from

Conversation

cyphar
Copy link
Member

@cyphar cyphar commented May 1, 2021

This PR needs 5 votes to pass:

Signed-off-by: Aleksa Sarai cyphar@cyphar.com

@cyphar cyphar added this to the 1.0.0-rc94 milestone May 1, 2021
Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moby CI is failing: #2928

AkihiroSuda
AkihiroSuda previously approved these changes May 1, 2021
Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#2928 is an issue of Moby, not runc, so still LGTM

@kolyshkin
Copy link
Contributor

A couple of minor PRs we might want to merge before are:

Not super important though, so this LGTM.

@cyphar
Copy link
Member Author

cyphar commented May 3, 2021

I've also noticed that scripts/release.sh appears to not work on my machine anymore so I might want to debug that before we do a release...

EDIT: We need to do a go clean -cache in script/release.sh because apparently Go now caches pkg-config...

@kolyshkin
Copy link
Contributor

EDIT: We need to do a go clean -cache in script/release.sh because apparently Go now caches pkg-config...

The alternative is adding -a to go build flags. I haven't tested it, but if it works, we can do something like

diff --git a/script/release.sh b/script/release.sh
index 2156fca3..d2190ce8 100755
--- a/script/release.sh
+++ b/script/release.sh
@@ -62,7 +62,7 @@ EOF
        )
        mv "$tarball"{,.asc} "$builddir"
 
-       make -C "$root" PKG_CONFIG_PATH="${prefix}/lib/pkgconfig" COMMIT_NO= static
+       make -C "$root" PKG_CONFIG_PATH="${prefix}/lib/pkgconfig" COMMIT_NO= EXTRA_FLAGS="-a" static
        rm -rf "$prefix"
        mv "$root/$project" "$1"
 }

@kolyshkin
Copy link
Contributor

Source for the above: golang/go#24544 (comment)

@mrunalp
Copy link
Contributor

mrunalp commented May 3, 2021

LGTM

kolyshkin
kolyshkin previously approved these changes May 3, 2021
Copy link
Contributor

@kolyshkin kolyshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyphar
Copy link
Member Author

cyphar commented May 4, 2021

/ping @opencontainers/runc-maintainers

It would be nice if I could do the release tomorrow.

@kolyshkin kolyshkin requested review from crosbymichael, dqminh and hqhq May 4, 2021 19:31
dqminh
dqminh previously approved these changes May 4, 2021
@dqminh
Copy link
Contributor

dqminh commented May 4, 2021

LGTM

@kolyshkin kolyshkin marked this pull request as draft May 4, 2021 23:38
@kolyshkin
Copy link
Contributor

I think I found a regression which better be fixed before we release rc94; will have a PR ready shortly (and changed this one to draft so we won't merge it earlier).

@kolyshkin
Copy link
Contributor

I think I found a regression which better be fixed before we release rc94; will have a PR ready shortly

#2936

@hqhq
Copy link
Contributor

hqhq commented May 8, 2021

I think I found a regression which better be fixed before we release rc94; will have a PR ready shortly

#2936

I figured the alternative fix #2937 is merged, so LGTM now.

@hqhq
Copy link
Contributor

hqhq commented May 8, 2021

LGTM

hqhq
hqhq previously approved these changes May 8, 2021
@cyphar
Copy link
Member Author

cyphar commented May 8, 2021

I will rebase this and we can just take all the LGTMs as a pass for this release. 😅

@cyphar cyphar dismissed stale reviews from hqhq, dqminh, kolyshkin, and AkihiroSuda via 90272e7 May 8, 2021 08:33
@cyphar cyphar marked this pull request as ready for review May 8, 2021 08:33
@AkihiroSuda
Copy link
Member

@cyphar Can we fix cgroup2 CI before rc94? #2944

@cyphar
Copy link
Member Author

cyphar commented May 8, 2021

Yeah let's do that first. I'll review it on Monday.

cyphar added 2 commits May 10, 2021 11:17
Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
@cyphar
Copy link
Member Author

cyphar commented May 10, 2021

I've rebased this again -- @opencontainers/runc-maintainers can I get two LGTMs to be able to merge the release PR? Thanks.

@dqminh
Copy link
Contributor

dqminh commented May 10, 2021

LGTM

@cyphar cyphar closed this in 4d72b36 May 10, 2021
@cyphar cyphar deleted the release-rc94 branch May 10, 2021 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants