-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VERSION: release 1.0.0-rc94 #2927
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moby CI is failing: #2928
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#2928 is an issue of Moby, not runc, so still LGTM
A couple of minor PRs we might want to merge before are:
Not super important though, so this LGTM. |
I've also noticed that EDIT: We need to do a |
The alternative is adding diff --git a/script/release.sh b/script/release.sh
index 2156fca3..d2190ce8 100755
--- a/script/release.sh
+++ b/script/release.sh
@@ -62,7 +62,7 @@ EOF
)
mv "$tarball"{,.asc} "$builddir"
- make -C "$root" PKG_CONFIG_PATH="${prefix}/lib/pkgconfig" COMMIT_NO= static
+ make -C "$root" PKG_CONFIG_PATH="${prefix}/lib/pkgconfig" COMMIT_NO= EXTRA_FLAGS="-a" static
rm -rf "$prefix"
mv "$root/$project" "$1"
} |
Source for the above: golang/go#24544 (comment) |
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/ping @opencontainers/runc-maintainers It would be nice if I could do the release tomorrow. |
LGTM |
I think I found a regression which better be fixed before we release rc94; will have a PR ready shortly (and changed this one to draft so we won't merge it earlier). |
|
LGTM |
I will rebase this and we can just take all the LGTMs as a pass for this release. 😅 |
90272e7
Yeah let's do that first. I'll review it on Monday. |
Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
I've rebased this again -- @opencontainers/runc-maintainers can I get two LGTMs to be able to merge the release PR? Thanks. |
LGTM |
This PR needs 5 votes to pass:
Signed-off-by: Aleksa Sarai cyphar@cyphar.com