[rc94 regression] libct/cg/sd: fix dbus error handling #2997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes isDbusError function, introduced by commit bacfc2c. Due to a type error it was not working at all. This also fixes the whole "retry on dbus disconnect" logic. This also fixes a regression in startUnit (and cgroupManager.Apply()), which should never return "unit already exists" error but it did. Fixes: bacfc2c Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
mrunalp
approved these changes
Jun 3, 2021
AkihiroSuda
approved these changes
Jun 4, 2021
This was referenced Jun 7, 2021
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes
isDbusErrorfunction, introduced by commit bacfc2c. Due to atype error it was not working at all.
This also fixes the whole "retry on dbus disconnect" logic, introduced
in PR #2923. Most probably it was not working at all before this fix.
This also fixes a regression in
startUnit(andcgroupManager.Apply()),which should never return "unit already exists" error but it did (#2996).
A test case is added to check that the last issue is fixed.
Fixes: bacfc2c
Fixes: #2996
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1941456
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1965545
Proposed changelog entry