Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop Go 1.15 support #3245

Merged
merged 4 commits into from
Oct 17, 2021
Merged

Drop Go 1.15 support #3245

merged 4 commits into from
Oct 17, 2021

Commits on Oct 14, 2021

  1. ci/gha: install latest stable Go version 

    Jobs verify/compile-buildtags and verify/deps relied on whatever Go
version is available from the Ubuntu-20.04 image, which seems to be
1.15.x).

Job test/cross-i386 was installing whatever Go version is considered to
be the default one by actions/setup-go@v2, which seems to be go 1.15.15
at the moment.

Fix all three jobs to install Go 1.x (which should translate to latest
stable Go version, i.e. 1.17.2 as of now).

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
    @kolyshkin
    kolyshkin committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    3d98676 View commit details
    Browse the repository at this point in the history

  2. Require Go >= 1.16 

    Go 1.15 is not supported since Go 1.17 release (16 Aug 2021), and some
packages that we use already require Go 1.16+ (notably,
github.com/cilium/ebpf v0.7.0).

Let's require Go 1.16+.

Remove Go version requirement from README when describing dependencies,
since it is no longer needed:

	$ GO=go1.15.15 make vendor
	go1.15.15 mod tidy
	go mod tidy: go.mod file indicates go 1.16, but maximum supported version is 1.15
	make: *** [Makefile:141: vendor] Error 1

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
    @kolyshkin
    kolyshkin committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    12e99a0 View commit details
    Browse the repository at this point in the history

  3. libcontainer/ignoreTerminateErrors: simplify for Go 1.16+ 

    One less TODO in the code, yay!

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
    @kolyshkin
    kolyshkin committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    6a4f4a6 View commit details
    Browse the repository at this point in the history

  4. Remove io/ioutil use 

    See https://golang.org/doc/go1.16#ioutil

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
    @kolyshkin
    kolyshkin committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    5516294 View commit details
    Browse the repository at this point in the history