Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

specconv: do not permit null bytes in mount fields #3287

Merged
merged 1 commit into from
Nov 19, 2021
Merged

specconv: do not permit null bytes in mount fields #3287

merged 1 commit into from
Nov 19, 2021

Commits on Nov 19, 2021

  1. specconv: do not permit null bytes in mount fields 

    Using null bytes as control characters for sending strings via netlink
opens us up to a user explicitly putting a null byte in a mount string
(which JSON will happily let you do) and then causing us to open a mount
path different to the one expected.

In practice this is more of an issue in an environment such as
Kubernetes where you may have path-based access control policies (which
are more susceptible to these kinds of flaws).

Found by Google Project Zero.

Fixes: 9c44407 ("Open bind mount sources from the host userns")
Reported-by: Felix Wilhelm <fwilhelm@google.com>
Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
    @cyphar
    cyphar committed Nov 19, 2021
    Configuration menu
    Copy the full SHA
    dde509d View commit details
    Browse the repository at this point in the history