Minor cleanups in libcontainer and loadFactory #3340
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove unneeded wrapping func, as intelrdt.NewManager already has the correct signature. - reverse the if/else to be clearer that either "IsCATEnabled()" and/or "IsMBAEnabled()" need to be enabled (and to allow skipping one of those checks in the condition). Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
commented
Jan 19, 2022
| if !intelrdt.IsCATEnabled() && !intelrdt.IsMBAEnabled() { | ||
| l.NewIntelRdtManager = nil | ||
| if intelrdt.IsCATEnabled() || intelrdt.IsMBAEnabled() { | ||
| l.NewIntelRdtManager = intelrdt.NewManager |
There was a problem hiding this comment.
FWIW; wondering why NewIntelRdtManager (and other fields in LinuxFactory are exported; perhaps they should not be)
|
Can we please have this one after #3316? That one is a major refactoring and is removing some stuff which is modified here. |
|
Yes! Fine to do it after, if anything is left then (I didn't see those changes until after I created this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libct.IntelRdtFs(): simplify
loadFactory(): remove unneeded intermediate variable