[1.1] libct/cg/sd: check dbus.ErrClosed instead of isDbusError #3476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kolyshkin
changed the title
AkihiroSuda
approved these changes
May 21, 2022
Signed-off-by: Kang Chen <kongchen28@gmail.com> (cherry picked from commit 0ca0bb9) Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Merged
This was referenced Jun 2, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of #3475 to release-1.1 branch. Original description follows:
This fixes dbus.ErrClosed checker in "retry on dbus disconnect" logic, introduced in PR #2923.
dbus.ErrClosedis not a dbus.Error.It can reproduce in kubelet:
systemctl restart dbusin this nodedbus: connection closed by userSo kubernetes need to bump libct with this fix.