Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cgroups: systemd: skip adding device paths that don't exist #3498

Merged
merged 1 commit into from
Jun 8, 2022
Merged

cgroups: systemd: skip adding device paths that don't exist #3498

merged 1 commit into from
Jun 8, 2022

Conversation

cyphar
Copy link
Member

@cyphar cyphar commented Jun 2, 2022

systemd emits very loud warnings when the path specified doesn't exist
(which can be the case for some of our default rules). We don't need the
ruleset we give systemd to be completely accurate (we discard some kinds
of wildcard rules anyway) so we can safely skip adding these.

Signed-off-by: Aleksa Sarai cyphar@cyphar.com

systemd emits very loud warnings when the path specified doesn't exist
(which can be the case for some of our default rules). We don't need the
ruleset we give systemd to be completely accurate (we discard some kinds
of wildcard rules anyway) so we can safely skip adding these.

Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
@cyphar cyphar marked this pull request as ready for review June 2, 2022 06:06
Copy link
Contributor

@kolyshkin kolyshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyphar cyphar added this to the 1.1.3 milestone Jun 7, 2022
@kolyshkin kolyshkin added easy-to-review backport/1.1-done A PR in main branch which has been backported to release-1.1 labels Jun 7, 2022
@cyphar cyphar mentioned this pull request Jun 7, 2022
@cyphar cyphar requested a review from a team June 7, 2022 23:55
@kolyshkin
Copy link
Contributor

@thaJeztah @AkihiroSuda PTAL

@kolyshkin kolyshkin modified the milestones: 1.1.3, 1.2.0 Jun 8, 2022
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah merged commit 258eff1 into opencontainers:main Jun 8, 2022
@cyphar cyphar deleted the systemd-devices-nonexistent-files branch June 8, 2022 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cgroupv1 area/systemd backport/1.1-done A PR in main branch which has been backported to release-1.1 easy-to-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants