Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix centos 7 ci #3614

Merged
merged 3 commits into from
Sep 28, 2022
Merged

Fix centos 7 ci #3614

merged 3 commits into from
Sep 28, 2022

Conversation

kolyshkin
Copy link
Contributor

@kolyshkin kolyshkin commented Sep 27, 2022

Turns out, CentOS 7 image used in Cirrus CI had EPEL repo configured, and now it's not. This, together with a "feature" of older yum NOT returning an error when some of the packages requested are not found, resulted in failures in tests that use jq and fuse-sshfs.

The fix is to add/enable EPEL repo.

1.1 backport: #3618

@AkihiroSuda AkihiroSuda added area/ci backport/1.1-todo A PR in main branch which needs to be backported to release-1.1 labels Sep 27, 2022
@kolyshkin kolyshkin force-pushed the fix-centos-7-ci branch 3 times, most recently from 1936333 to 82ae1fb Compare September 28, 2022 05:19
@kolyshkin
Copy link
Contributor Author

OK, the issue seems that in CentOS 7 image used by Cirrus CI, EPEL is no longer enabled, despite the docs at https://cloud.google.com/compute/docs/images/os-details (under "Image configuration") saying

For CentOS 7, EPEL is enabled.

I am pretty sure it used to be enabled, but apparently Google Cloud has changed something.

The other part of the story is yum from CentOS 7 does not fail (== return exit code of 0) when some requested packages are not found.

The situation when /sys/fs/cgroup/unified is not present normal and
should not result in anything on stderr. Suppress it.

Fixes: cc15b88
Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
We use awk in other 9 or so places, and here it's gawk.
Since this is on Linux, most probably awk is gawk.

So s/gawk/awk/.

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
It used to be enabled by default, but not as of last few weeks.

While at it, add rpm -q command to make sure all required RPMS were in
fact installed (at least CentOS 7 yum exits with 0 when some packages
requested are not available).

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
@kolyshkin kolyshkin marked this pull request as ready for review September 28, 2022 18:04
@kolyshkin kolyshkin mentioned this pull request Sep 28, 2022
@kolyshkin kolyshkin added backport/1.1-done A PR in main branch which has been backported to release-1.1 and removed backport/1.1-todo A PR in main branch which needs to be backported to release-1.1 labels Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci backport/1.1-done A PR in main branch which has been backported to release-1.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants