Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Init State Error Variable #3662

Merged

Conversation

vipulnewaskar7
Copy link
Contributor

Init State Error message was using the err variable instead of uerr, which has been fixed now. The error message should not show "nil" now.

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors. 660 York Street, Suite 102,
San Francisco, CA 94110 USA

Everyone is permitted to copy and distribute verbatim copies of this license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or

(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.

(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

Signed-off-by: Vipul Newaskar vipulnewaskar7@gmail.com

@kolyshkin
Copy link
Contributor

  1. You don't have to put the text of the DCO into your commit message.

  2. No need to Capitalize Every Word In Commit Subject.

Please fix; otherwise LGTM

Init State Error message was using the err variable instead of uerr, which has been fixed now.
The error message should not show "nil" now.

Signed-off-by: Vipul Newaskar <vipulnewaskar7@gmail.com>
@vipulnewaskar7 vipulnewaskar7 force-pushed the 3659-wrong-error-variable-fix branch from a8f5137 to 9fc707e Compare November 15, 2022 04:16
@vipulnewaskar7
Copy link
Contributor Author

Hi @kolyshkin
I have fixed them. Please review it now.

Copy link
Contributor

@kolyshkin kolyshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

(the error was introduced in commit ba0246d)

@kolyshkin
Copy link
Contributor

@thaJeztah @AkihiroSuda PTAL

@mrunalp mrunalp merged commit c1045cc into opencontainers:main Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants