Fix undefined behavior of setjmp() macro. #3790
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accepting the return value of a C setjmp macro as a variable is undefined behavior and should generally not be considered safe.
reference: https://pubs.opengroup.org/onlinepubs/009604599/functions/setjmp.html
It was introduced for debugging purposes in the following commit, and earlier implementations did not have this problem.
64bb59f
The implementation has been modified to conform to C standards while maintaining this debugging information where possible.
In the default case, we have given up on displaying
current_stage.