Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/int: increase num retries for oom tests #3874

Merged
merged 1 commit into from
Jun 8, 2023

Conversation

kolyshkin
Copy link
Contributor

@kolyshkin kolyshkin commented May 18, 2023

This test is occasionally failing on CS9.

The test case always takes about 7 seconds on my laptop (decreasing
memory, using a different memory eater in shell etc. doesn't help).

Increase the number of iterations from 10 to 30 to make sure we don't
see any flakes.

Fixes: #3868

@kolyshkin kolyshkin force-pushed the fix-cs9-oom branch 4 times, most recently from d8f95ab to 1a0fc2d Compare May 22, 2023 21:01
@kolyshkin
Copy link
Contributor Author

Run this tests a lot of times on centos-stream-9 CI, it also finishes in 6-7 seconds. So, I am not convinved that increasing the timeout helps, but it won't hurt either.

@kolyshkin
Copy link
Contributor Author

CI failure on Fedora is unrelated; opened #3880 to fix.

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

but let me know if this was indeed the right thing (I see you commented above)

This test is occasionally failing on CS9.

The test case always takes about 7 seconds on my laptop (decreasing
memory, using a different memory eater in shell etc. doesn't help).

Increase the number of iterations from 10 to 30 to make sure we don't
see any flakes.

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
@kolyshkin kolyshkin added the backport/1.1-todo A PR in main branch which needs to be backported to release-1.1 label Jun 7, 2023
@kolyshkin kolyshkin merged commit f075e26 into opencontainers:main Jun 8, 2023
@kolyshkin kolyshkin added backport/1.1-done A PR in main branch which has been backported to release-1.1 and removed backport/1.1-todo A PR in main branch which needs to be backported to release-1.1 labels Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci backport/1.1-done A PR in main branch which has been backported to release-1.1 easy-to-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Occasional "events oom" failure on centos-stream-9
3 participants