Modifying cpu attribute data type as per specs #395
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: rajasec <rajasec79@gmail.com>
|
There is still discussion on going, opencontainers/runtime-spec#233 we are thinking about change the settings to points. I think we should hold on this PR for a while? |
|
Yes, we should wait for the spec discussion to conclude. |
|
I think we should transition all of the cgroup types, as per opencontainers/runtime-spec#233 (once it's merged), in one PR so we make sure we've covered everything upfront. |
|
This was fixed in the recent spec update |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per specs, modified cpu subsystem attributes to uint64 instead of int64
Signed-off-by: rajasec rajasec79@gmail.com