Avoid using runc-dmz if capabilities are set as non-root #4129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...unless they are in both the bounding and ambient sets, in which case things work as expected. Signed-off-by: David Leadbeater <dgl@dgl.cx>
This was referenced Nov 28, 2023
cyphar
requested changes
Nov 28, 2023
There was a problem hiding this comment.
Needs a different approach. See this comment in the original issue. (Sorry, I only finished writing it after you'd already posted this PR.)
| @@ -135,7 +135,7 @@ func (l *linuxSetnsInit) Init() error { | |||
| return &os.PathError{Op: "close log pipe", Path: "fd " + strconv.Itoa(l.logFd), Err: err} | |||
| } | |||
|
|
|||
| if l.dmzExe != nil { | |||
There was a problem hiding this comment.
This approach re-introduces the CVEs that runc-dmz is protecting against. If we have chosen to use runc-dmz at this point, not using it allows the container to gain write access to the host runc binary (because /proc/self/exe at this point is the actual binary, not a copy).
In order to take this approach, you will need to modify isDmzBinarySafe to detect this problem before we do runc init. Effectively you need to make a check that mirrors the dmz.WorksWithSELinux check.
|
Closing in favour of #4137. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...unless they are in both the bounding and ambient sets, in which case things work as expected.
Potential fix for #4125