Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libct/userns: split userns detection from internal userns code #4331

Merged
merged 1 commit into from
Jul 3, 2024

Commits on Jun 30, 2024

  1. libct/userns: split userns detection from internal userns code

    Commit 4316df8 isolated RunningInUserNS
    to a separate package to make it easier to consume without bringing in
    additional dependencies, and with the potential to move it separate in
    a similar fashion as libcontainer/user was moved to a separate module
    in commit ca32014. While RunningInUserNS
    is fairly trivial to implement, it (or variants of this utility) is used
    in many codebases, and moving to a separate module could consolidate
    those implementations, as well as making it easier to consume without
    large dependency trees (when being a package as part of a larger code
    base).
    
    Commit 1912d59 and follow-ups introduced
    cgo code into the userns package, and code introduced in those commits
    are not intended for external use, therefore complicating the potential
    of moving the userns package separate.
    
    This commit moves the new code to a separate package; some of this code
    was included in v1.1.11 and up, but I could not find external consumers
    of `GetUserNamespaceMappings` and `IsSameMapping`. The `Mapping` and
    `Handles` types (added in ba0b5e2) only
    exist in main and in non-stable releases (v1.2.0-rc.x), so don't need
    an alias / deprecation.
    
    Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
    thaJeztah committed Jun 30, 2024
    Configuration menu
    Copy the full SHA
    30b530c View commit details
    Browse the repository at this point in the history