Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add timens to default generated config.json #4573

Closed
wants to merge 2 commits into from

Conversation

akhilerm
Copy link
Contributor

  • add timens to generated config.json
  • fix tests to account for timens present in default config.json

Signed-off-by: Akhil Mohan <akhilerm@gmail.com>
Signed-off-by: Akhil Mohan <akhilerm@gmail.com>
@AkihiroSuda
Copy link
Member

Why?

@akhilerm
Copy link
Contributor Author

akhilerm commented Jan 1, 2025

Why?

So that the default generated config.json has all the supported namespaces. Also, as per the discussion here

@cyphar
Copy link
Member

cyphar commented Jan 2, 2025

Ah, I forgot that the time namespace doesn't allow a container to do settimeofday -- you need to set the time namespace offset at the beginning to do anything useful. This means that a configuration with just a time namespace and no offset doesn't really do anything.

So that the default generated config.json has all the supported namespaces.

The default configuration doesn't include user namespaces, for similar reasons. There is a stronger argument for making user namespaces enabled by default but you can't do that in a generic way.

@kolyshkin
Copy link
Contributor

I also think that time namespace is special and should not be enabled by default.

@akhilerm
Copy link
Contributor Author

akhilerm commented Jan 3, 2025

Closing the PR as the consensus is not to enable timens by default.

@akhilerm akhilerm closed this Jan 3, 2025
@akhilerm akhilerm deleted the add-time-ns-example branch January 3, 2025 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants