[1.3] Release v1.3.2 #4906
[1.3] Release v1.3.2 #4906
Conversation
kolyshkin
requested review from
cyphar and
rata
and removed request for
cyphar
Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
| ### Changed | ||
| * The conversion from cgroup v1 CPU shares to cgroup v2 CPU weight is | ||
| improved to better fit default v1 and v2 values. (#4772, #4785, #4897) | ||
| * Dependency github.com/opencontainers/cgroups updated from v0.0.1 to |
There was a problem hiding this comment.
This has already been mentioned in the previous item, so shall we remove it here?
There was a problem hiding this comment.
So, the dependency update brings in a few changes, two of which are spelled out and the rest is hiding behind this line.
rata
left a comment
rata
left a comment
There was a problem hiding this comment.
LGTM, thanks!
IMHO it feels weird to list the cgroup update PRs in several entries, I think the "dedicated" entry for the bump is enough and I'd remove it from the others.
In any case, I don't care that much tbh, I think this should be automated. I'm fine with this as it is too :-D
|
I think just having the bump entry doesn't properly convey what changes are included. This just leads to stuff like #4896. Ideally I would prefer that we provide a description of the changes relevant to runc in a single entry that mentions it is due to a dep bump. |
cyphar
left a comment
cyphar
left a comment
There was a problem hiding this comment.
@kolyshkin Do you already have a release ready or would you like me to do it?
Am making it myself |
|
https://github.com/opencontainers/runc/releases/tag/v1.3.2 @cyphar feel free to change the release announcement if I missed something (hope I did not). |
|
Looks good to me, thanks! |
4 participants
Changed
improved to better fit default v2 weights (Conversion of cgroup v1 CPU shares to v2 CPU weight causes workloads to have low CPU priority #4772, deps: bump cgroups to v0.0.3, fix a few regressions #4785, [1.3] bump cgroups to v0.0.4 + related test fixes #4897)
v0.0.4. ([1.3] bump cgroups to v0.0.4 + related test fixes #4897)
Fixed
([bug] cgroup.freeze: no such device #4798, build(deps): bump github.com/opencontainers/cgroups from 0.0.3 to 0.0.4 #4808, [1.3] bump cgroups to v0.0.4 + related test fixes #4897)
kernel was rounding memory limit to 64K. (runc cgroups test fails on ppc64le #4841, [1.3] tests/int/cgroups: Use 64K aligned limits for memory.max #4895, tests/int/cgroups: Use 64K aligned limits for memory.max #4893)