Handle memory swappiness default properly #580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this is reasonable as the only way to have an "unset" value is to explicitly default to "-1" in the actual implementation, which is the libcontainer |
|
What do you think about making the type on the libcontainer config a pointer so that it can actually be nil and we treat nil and -1 as the same thing for backwards compat? |
|
@crosbymichael sounds good.. I went for simplest approach, but backwards compat sounds like a good thing. I'll rework |
estesp
force-pushed
the
swappiness-fix
branch
3 times, most recently
from
ca41492 to
94ece21
Compare
This prior fix to set "-1" explicitly was lost, and it is simpler to use the same pointer type from the OCI spec to handle nil pointer == -1 == unset case. Also, as a nearly humorous aside, there was a test for MemorySwappiness that was actually setting Memory, and it was passing because of this bug (as it was always setting everyone's MemorySwappiness to zero!) Docker-DCO-1.1-Signed-off-by: Phil Estes <estesp@linux.vnet.ibm.com> (github: estesp)
estesp
force-pushed
the
swappiness-fix
branch
from
94ece21 to
0b5581f
Compare
estesp
changed the title
|
LGTM |
|
LGTM |
LK4D4
added a commit
that referenced
this pull request
Feb 24, 2016
Handle memory swappiness default properly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prior fix was lost in other refactorings of the codebase.
Docker-DCO-1.1-Signed-off-by: Phil Estes estesp@linux.vnet.ibm.com (github: estesp)
Fixes: #543
Fixes: #575