Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define State for container and runtime namespace #1045

Merged
merged 1 commit into from
May 21, 2020

Conversation

RenaudWasTaken
Copy link
Contributor

Hello!

As a followup of the OCI Weekly Discussion on 5/20/2020, as well as discussions on the runc hooks Pull Request, I've updated the definition of the PID field for the state structure.

We are updating it with the following definition in mind:

  • Runtime namespace hooks get runtime/absolute information
  • Container Namespace hooks get container/relative information

/cc @cyphar @mrunalp @mikebrow

Signed-off-by: Renaud Gaubert rgaubert@nvidia.com

Signed-off-by: Renaud Gaubert <rgaubert@nvidia.com>
@tianon
Copy link
Member

tianon commented May 20, 2020

LGTM

Approved with PullApprove

@cyphar
Copy link
Member

cyphar commented May 21, 2020

LGTM.

Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mrunalp
Copy link
Contributor

mrunalp commented May 21, 2020

LGTM

Approved with PullApprove

@mrunalp mrunalp merged commit e548728 into opencontainers:master May 21, 2020
@AkihiroSuda AkihiroSuda mentioned this pull request Jan 24, 2023
@AkihiroSuda AkihiroSuda added this to the v1.1.0 milestone Feb 1, 2023
@AkihiroSuda AkihiroSuda mentioned this pull request Jun 26, 2023
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants