Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pandoc: point to a joint OCI org image #1078

Closed
wants to merge 1 commit into from
Closed

pandoc: point to a joint OCI org image #1078

wants to merge 1 commit into from

Conversation

vbatts
Copy link
Member

@vbatts vbatts commented Dec 7, 2020

Signed-off-by: Vincent Batts vbatts@hashbangbash.com

@vbatts
pandoc: point to a joint OCI org image
f7280b1 
Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>
@alban
Copy link
Contributor

alban commented Dec 7, 2020

LGTM. Thanks @vbatts

For the record, before this PR, Travis tests was sometimes failing with:

$ docker pull vbatts/pandoc
Using default tag: latest
Error response from daemon: received unexpected HTTP status: 500 Server Error
The command "docker pull vbatts/pandoc" failed and exited with 1 during .

tianon
tianon reviewed Dec 7, 2020
View reviewed changes
Makefile
@@ -4,6 +4,8 @@ OUTPUT_DIRNAME ?= output
DOC_FILENAME ?= oci-runtime-spec
DOCKER ?= $(shell command -v docker 2>/dev/null)
PANDOC ?= $(shell command -v pandoc 2>/dev/null)

PANDOC_CONTAINER ?= quay.io/oci/pandoc:1.17.0.3-2.fc25.x86_64
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
PANDOC_CONTAINER ?= quay.io/oci/pandoc:1.17.0.3-2.fc25.x86_64
PANDOC_IMAGE ?= quay.io/oci/pandoc:1.17.0.3-2.fc25.x86_64

😇

Given this version string is now much more complex than trusting vbatts/pandoc:latest, would it also make sense to either have a docker pull $(PANDOC_IMAGE) target or perhaps have install.tools do that?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(To avoid the .travis.yml duplication, which will inevitably get out of sync or trip folks up if they need to bump this for whatever reason)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quay.io/oci/pandoc:latest seems to work fine. Is there any reason for using an older version?

@kevpar kevpar mentioned this pull request Mar 30, 2021
Closed
@tianon tianon mentioned this pull request Aug 31, 2021
Closed
@jdolitsky
Copy link
Member

Can we modify to use the image located at https://github.com/opencontainers/container-images?

ghcr.io/opencontainers/pandoc:2.9.2.1-8.fc33.x86_64@sha256:5d81ff930a043295a557be8b003ece2a33d14e91b28c50d368413b83372f8d28

@jdolitsky jdolitsky mentioned this pull request Oct 29, 2021
Merged
@vbatts
Copy link
Member Author

vbatts commented Apr 20, 2022

stale PR

@vbatts vbatts closed this Apr 20, 2022
@vbatts vbatts deleted the change_image branch April 20, 2022 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tianon tianon tianon left review comments

@giuseppe giuseppe giuseppe left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vbatts @alban @jdolitsky @giuseppe @tianon