Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: add annotation for exec isolated CPU affinity #1252

Conversation

bartwensley
Copy link

The runc container runtime recently introduced functionality to direct exec operations to the first isolated CPU in a container cgroup cpuset. This is enabled through a new runc specific container annotation: org.opencontainers.runc.exec.isolated-cpu-affinity-transition

See opencontainers/runc@afc23e3397 for the details.

This new functionality is also required in the crun container runtime and will be added soon. This purpose of this commit is to add a new annotation to the OCI runtime specification that would be used by any runtime that implements this new functionality:
org.opencontainers.runtime.exec.isolated-cpu-affinity-transition

The runc implementation should switch to using the new annotation once it is accepted.

The runc container runtime recently introduced functionality to direct exec
operations to the first isolated CPU in a container cgroup cpuset. This is
enabled through a new runc specific container annotation:
org.opencontainers.runc.exec.isolated-cpu-affinity-transition

See opencontainers/runc@afc23e3397 for the details.

This new functionality is also required in the crun container runtime and will
be added soon. This purpose of this commit is to add a new annotation to the
OCI runtime specification that would be used by any runtime that implements
this new functionality:
org.opencontainers.runtime.exec.isolated-cpu-affinity-transition

The runc implementation should switch to using the new annotation once it is
accepted.

Signed-off-by: Bart Wensley <bwensley@redhat.com>
Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be a proper JSON field

@tianon
Copy link
Member

tianon commented May 17, 2024

Agree -- a runtime-specific annotation seems like a really great way for one runtime to experiment with adding functionality like this before it's fully standardized or proven out, but as soon as it's something desirable for interoperability, it seems worth making a proper "feature" instead.

@bartwensley
Copy link
Author

I am abandoning this in favor of #1253

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants