Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix value of swappiness #279

Merged
merged 1 commit into from
Jan 4, 2016

Conversation

hqhq
Copy link
Contributor

@hqhq hqhq commented Dec 22, 2015

It's officially pointer of uint64 now, no point it can be
-1, change it to 0 as other fields in example.

Signed-off-by: Qiang Huang h.huangqiang@huawei.com

It's officially pointer of uint64 now, no point it can be
-1, change it to 0 as other fields in example.

Signed-off-by: Qiang Huang <h.huangqiang@huawei.com>
@wking
Copy link
Contributor

wking commented Dec 22, 2015

On Mon, Dec 21, 2015 at 10:59:50PM -0800, Qiang Huang wrote:

It's officially pointer of uint64 now, no point it can be
-1, change it to 0 as other fields in example.

e4b4ba2 looks good to me. But just to be clear, the old -1 (don't
touch this) maps to not not setting this key (or setting the value to
null) in the post-#233 pointer world. 0 swappiness has always meant
“prevents from any swapping even if there is a swap storage available”
1.

@philips
Copy link
Contributor

philips commented Dec 23, 2015

Yea, I think for illustrative purposes of showing the available fields this is fine. LGTM

@vbatts
Copy link
Member

vbatts commented Jan 4, 2016

LGTM

vbatts added a commit that referenced this pull request Jan 4, 2016
@vbatts vbatts merged commit 433abe0 into opencontainers:master Jan 4, 2016
@hqhq hqhq deleted the hq_fix_swappiness_value branch January 5, 2016 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants