-
Notifications
You must be signed in to change notification settings - Fork 554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Config] Make mount options format per-platform #439
Conversation
The fstab format (https://wiki.archlinux.org/index.php/Fstab) may be appropriate for Linux, but may not be appropriate for other OS platforms. This edit clarifies that mount options for Linux (and Solaris per @JLB13) MUST be in fstab format but leaves the format of options as open for other operating systems to clarify. This replaces PR opencontainers#432 Signed-off-by: Rob Dolin <RobDolin@microsoft.com>
On Wed, May 18, 2016 at 11:51:26AM -0700, Rob Dolin (MSFT) wrote:
50532d0 looks fine to me. I can file a change to link the man page |
I don't think we should call out an explicit must for Solaris to use a format defined for Linux. My comment was meant to indicate something like the existing format would be fine for Solaris. This wasn't meant to map explicitly to a requirement related to fstab format (which seems to be related to vfstab in Solaris). I'd be happy just leaving the bit about it for Linux, and other platforms can define their own formats. Speaking of, should each OS have its own definition in this space? It seems like we could either use the platform section or have a platform label as part of the mount specification. |
On Wed, May 18, 2016 at 12:25:37PM -0700, Jesse Butler wrote:
Can you give a link to the vfstab docs? Or whatever the spec is
This came up briefly again in today's meeting. Here's my recording of |
I mentioned vfstab in passing, we would likely not use that. We would likely use the filesystem (or 'fs') resource in zonecfg for Solaris. This is discussed in our documentation in various places (This[1] seems to be about the best place to hang a hat that I can find at the moment). If it's helpful, the abstract configuration looks something like this for a given mount: fs $identifier: [1] http://docs.oracle.com/cd/E53394_01/html/E54752/z.admin.ov-2.html#VLZSOz.admin.ov-26 |
On Wed, May 18, 2016 at 04:59:40PM -0700, Jesse Butler wrote:
That doesn't talk much about which (filesystem-dependent) options are |
Is this PR still relevant? In current * **`options`** (list of strings, OPTIONAL) Mount options of the filesystem to be used.
Linux: [supported][mount.8-filesystem-independent] [options][mount.8-filesystem-specific] are listed in [mount(8)][mount.8]. |
On Fri, Nov 04, 2016 at 03:12:53PM -0700, Tianon Gravi wrote:
+1 to closing this as “fixed by #443”. |
Fixed by #443 |
The fstab format (https://wiki.archlinux.org/index.php/Fstab) may be appropriate for Linux, but may not be appropriate for other OS platforms.
This edit clarifies that mount options for Linux (and Solaris per @JLB13) MUST be in fstab format but leaves the format of options as open for other operating systems to clarify.
This replaces PR #432
Signed-off-by: Rob Dolin RobDolin@microsoft.com