Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ Runtime ] Add example with a Windows bundlePath #460

Closed
wants to merge 1 commit into from

Conversation

RobDolinMS
Copy link
Collaborator

Adds an example with a Windows bundlePath value

Signed-off-by: Rob Dolin RobDolin@microsoft.com

Adds an example with a Windows bundlePath value

Signed-off-by: Rob Dolin <RobDolin@microsoft.com>
{
"ociVersion": "0.2.0",
"id": "oci-container1",
"pid": 4422,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably worth waiting until #459 settles for this.

And it would be good to get anchor-headers.

Copy link
Member

@tianon tianon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tianon
Copy link
Member

tianon commented Nov 4, 2016

Looks like PullApprove claims you're missing Signed-off-by again, although that's not the case....

@mrunalp
Copy link
Contributor

mrunalp commented Jan 11, 2017

@RobDolinMS could you make a trivial change and push again? (like modify the pid)

@mrunalp mrunalp closed this Jan 11, 2017
@mrunalp mrunalp reopened this Jan 11, 2017
@crosbymichael crosbymichael self-assigned this Feb 2, 2017
@crosbymichael
Copy link
Member

@RobDolinMS when you have time please rebase your PRs and make sure your sign off is correct. Feel free to reopen when they have been updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants