Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add governance and release process docs #521

Merged
merged 1 commit into from
Jul 25, 2016

Conversation

caniszczyk
Copy link
Contributor

@wking
Copy link
Contributor

wking commented Jul 22, 2016 via email

@cyphar
Copy link
Member

cyphar commented Jul 23, 2016

LGTM, as discussed on the mailing list.

Approved with PullApprove

@wking
Copy link
Contributor

wking commented Jul 23, 2016

On Fri, Jul 22, 2016 at 08:25:01PM -0700, Aleksa Sarai wrote:

LGTM, as discussed on the mailing list.

I'm fairly positive about this change, and I feel like it's already
been approved by runtime-spec maintainers [1,2]:

+8 Alexander Morozov, Brandon Philips, Daniel Dao, Mrunal Patel, Qiang
Huang, Tianon Gravi, Vincent Batts, Vishnu Kannan
-0
#1 Michael Crosby

But as a purely technical question, why does your LGTM get the
PullApprove button? It's configured to look at
runtime-spec-maintainers 3, and you aren't one [4](yet? ;).

 Subject: [project-template adopted]: Merge 56abe122 (+13 -0 #5)
 Date: Wed, 20 Jul 2016 16:51:58 +0000
 Message-ID: <CAD2oYtPwMcF__WD32cV6dHgHt8=F6qFw+XFGw4iQK9LGi_QWsg@mail.gmail.com>

 Subject: Add governance and releases docs

@vbatts
Copy link
Member

vbatts commented Jul 23, 2016

LGTM

On Sat, Jul 23, 2016, 00:00 W. Trevor King notifications@github.com wrote:

On Fri, Jul 22, 2016 at 08:25:01PM -0700, Aleksa Sarai wrote:

LGTM, as discussed on the mailing list.

I'm fairly positive about this change, and I feel like it's already
been approved by runtime-spec maintainers [1,2]:

+8 Alexander Morozov, Brandon Philips, Daniel Dao, Mrunal Patel, Qiang
Huang, Tianon Gravi, Vincent Batts, Vishnu Kannan
-0
#1 Michael Crosby

But as a purely technical question, why does your LGTM get the
PullApprove button? It's configured to look at
runtime-spec-maintainers [3], and you aren't one [4](yet? ;).

Subject: [project-template adopted]: Merge 56abe122 (+13 -0 #5)
Date: Wed, 20 Jul 2016 16:51:58 +0000
Message-ID: <CAD2oYtPwMcF__WD32cV6dHgHt8=
F6qFw+XFGw4iQK9LGi_QWsg@mail.gmail.com>
[2]:
opencontainers/project-template#15 (comment)
Subject: Add governance and releases docs
[3]:

- runtime-spec-maintainers

[4]:
https://github.com/opencontainers/runtime-spec/blob/bb6925ea99f0e366a3f7d1c975f6577475ca25f0/MAINTAINERS


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#521 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAEF6dmOrl9GvssXofNjuHZHKvhQ5ueKks5qYZHSgaJpZM4JTCu7
.

@cyphar
Copy link
Member

cyphar commented Jul 23, 2016

I have no clue why I get a pull approve button. Maybe it's a sign? 😉

@wking
Copy link
Contributor

wking commented Jul 23, 2016

On Sat, Jul 23, 2016 at 05:41:35AM -0700, Vincent Batts wrote:

LGTM

And @vbatts does not get a PullApprove button? Maybe someone has
mixed up runc-maintainers and runtime-spec-maintainers when populating
the GitHub groups?

@cyphar
Copy link
Member

cyphar commented Jul 23, 2016

I just checked. @vbatts is in the runtime-spec-maintainers group, and so am I (which I think is a mistake caused by all of the reorganisation of the groups, I'll leave it now).

@wking
Copy link
Contributor

wking commented Jul 23, 2016

On Sat, Jul 23, 2016 at 08:18:27AM -0700, Aleksa Sarai wrote:

@vbatts is in the runtime-spec-maintainers group, and so am I (which
I think is a mistake, I'll leave it now).

So that explains why you got the button, but we're still not sure why
@vbatts didn't.

@dqminh
Copy link
Contributor

dqminh commented Jul 25, 2016

LGTM

Approved with PullApprove

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants