Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

specs-go/config: Drop "this field is platform dependent" (again) #569

Merged

Conversation

wking
Copy link
Contributor

@wking wking commented Sep 15, 2016

We dropped these in #568 but #565 was developed in parallel and brought in a new one.

We dropped these in 4774080 (specs-go/config: Drop "this field is
platform dependent", 2016-09-14, opencontainers#568) but f9e48e0 (Windows: User
struct changes, 2016-09-14, opencontainers#565) was developed in parallel and
brought in a new one.

Signed-off-by: W. Trevor King <wking@tremily.us>
@tianon
Copy link
Member

tianon commented Sep 15, 2016

LGTM

Approved with PullApprove

@lowenna
Copy link
Contributor

lowenna commented Sep 15, 2016

LGTM (I am not a maintainer on this project)

@vbatts
Copy link
Member

vbatts commented Sep 15, 2016

LGTM

Approved with PullApprove

@vbatts vbatts merged commit b9e85b0 into opencontainers:master Sep 15, 2016
@wking wking deleted the drop-platform-dependent-comment-v2 branch September 15, 2016 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants