config: Use REQUIRED and OPTIONAL for properties #574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In all of these cases we want to use the RFC 2119 semantics. Generated with: $ sed -i 's/optional/OPTIONAL/g' config*.md Signed-off-by: W. Trevor King <wking@tremily.us>
In all of these cases we want to use the RFC 2119 semantics. Generated with: $ sed -i 's/required/REQUIRED/g' config*.md after which I rolled back the change for: ...controllers required to fulfill... since that was already MUSTed. Signed-off-by: W. Trevor King <wking@tremily.us>
|
LGTM |
1 similar comment
|
LGTM |
wking
added a commit
to wking/opencontainer-runtime-spec
that referenced
this pull request
Nov 10, 2016
This happened in c35cf57 (config: Replace "optional" with "OPTIONAL", 2016-09-17, opencontainers#574) but was accidentally rolled back in 52f3cde (Clarify wording for terminal setting and /dev/console, 2016-07-18, opencontainers#518). Signed-off-by: W. Trevor King <wking@tremily.us>
wking
added a commit
to wking/opencontainer-runtime-spec
that referenced
this pull request
Nov 14, 2016
The shift happened in c35cf57 (config: Replace "optional" with "OPTIONAL", 2016-09-17, opencontainers#574) and the 'windows' entry landed in parallel with dc8f2c2 (Add support for Windows-based containers, 2016-09-16, opencontainers#573). Signed-off-by: W. Trevor King <wking@tremily.us>
wking
added a commit
to wking/opencontainer-runtime-spec
that referenced
this pull request
Nov 14, 2016
The shift happened in c35cf57 (config: Replace "optional" with "OPTIONAL", 2016-09-17, opencontainers#574) and the 'windows' entry landed in parallel with dc8f2c2 (Add support for Windows-based containers, 2016-09-16, opencontainers#573). Signed-off-by: W. Trevor King <wking@tremily.us>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it clear that these are part of configuration compliance by using
the RFC 2119 keywords.