-
Notifications
You must be signed in to change notification settings - Fork 553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
schema: fix items based on latest spec #655
schema: fix items based on latest spec #655
Conversation
Signed-off-by: Ma Shimiao <mashimiao.fnst@cn.fujitsu.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The same “we probably don't want to allow explicit null
” applies to UID and GID too, and probably a bunch of other settings in the JSON Schema as well. I'm fine addressing this in a follow-up PR if you don't want to handle it here.
@@ -245,6 +245,10 @@ | |||
"id": "https://opencontainers.org/schema/bundle/linux/resources/memory/kernel", | |||
"$ref": "defs.json#/definitions/int64Pointer" | |||
}, | |||
"kernelTCP": { | |||
"id": "https://opencontainers.org/schema/bundle/linux/resources/memory/kernelTCP", | |||
"$ref": "defs.json#/definitions/int64Pointer" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wking Can your comment be addressed in a separate PR? |
Signed-off-by: Ma Shimiao mashimiao.fnst@cn.fujitsu.com