[Runtime] Allow for excluding pid from state #661
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces #459 Signed-off-by: Rob Dolin (MSFT) <robdolin@microsoft.com>
dqminh
reviewed
Jan 18, 2017
| @@ -21,6 +21,7 @@ The value MAY be one of: | |||
|
|
|||
| Additional values MAY be defined by the runtime, however, they MUST be used to represent new runtime states not defined above. | |||
| * **`pid`**: (int) is the ID of the container process, as seen by the host. | |||
| The pid MAY be excluded or set to a value indicating empty or null if it is not seen by the host. | |||
There was a problem hiding this comment.
i wonder if its useful to further clarified what it means by "pid is not seen by the host". I only understand this phrase when reading background of https://github.com/opencontainers/runtime-spec/pull/459/files.
Perhaps something like:
pid MAY be excluded when the container's kernel is isolated from the host / or the host does not manage the container pids
There was a problem hiding this comment.
nit: there's some trailing whitespace on the current line.
|
@RobDolinMS Any specific reasons that you can't do rebase in #459 ? I'll be better to do rebase there so we can keep good tracking. |
This was referenced Jan 22, 2017
|
Please rebase your original PRs and not create new ones. Thanks! ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #459
Signed-off-by: Rob Dolin (MSFT) robdolin@microsoft.com