config-linux: RFC 2119 wording for oomScoreAdj #781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hqhq
reviewed
May 9, 2017
config-linux.md
Outdated
| For more information, see [the proc filesystem documentation section 3.1][procfs]. | ||
| * **`oomScoreAdj`** *(int, OPTIONAL)* adjusts the oom-killer score in `[pid]/oom_score_adj` for the container process's `[pid]` in a [proc pseudo-filesystem][procfs]. | ||
| If `oomScoreAdj` is set, the runtime MUST set `oom_score_adj` to the given value. | ||
| If `oomScoreAdj` is not set, the runtime MUST not change the value of `oom_score_adj`. |
wking
force-pushed
the
oomScoreAdj-rfc-2119
branch
from
e7fdcb8 to
e9a39e7
Compare
The previous wording hinted at, but did not require, this setting to be implemented via oom_score_adj. With the new wording, when proc is mounted at /proc, the container process can check this value by looking at /proc/self/oom_score_adj. Signed-off-by: W. Trevor King <wking@tremily.us>
|
LGTM |
1 similar comment
|
LGTM |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous wording hinted at, but did not require, this setting to be implemented via
oom_score_adj. With the new wording, when proc is mounted at/proc, the container process can check this value by looking at/proc/self/oom_score_adj.Part of #746.