Remove range limit #783
Merged
Remove range limit #783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zhouhao <zhouhao@cn.fujitsu.com>
wking
reviewed
Apr 27, 2017
| @@ -458,7 +458,7 @@ type WindowsMemoryResources struct { | |||
| type WindowsCPUResources struct { | |||
| // Number of CPUs available to the container. | |||
| Count *uint64 `json:"count,omitempty"` | |||
| // CPU shares (relative weight to other containers with cpu shares). Range is from 1 to 10000. | |||
| // CPU shares (relative weight to other containers with cpu shares). | |||
There was a problem hiding this comment.
You may want to wait on this until #777 lands, because the Windows folks are sounding like they'd like to return the explicit ranges to their settings (here and here). On the other hand, there's no need to list the range in the Go comments even if the Markdown spec gives a valid range. If we want to remove range comments from the Go types regardless of whether the spec gives a valid range, we can go ahead with this removal without waiting on #777.
|
LGTM |
1 similar comment
|
LGTM |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #780
Signed-off-by: zhouhao zhouhao@cn.fujitsu.com