schema: bug fixes #784
Merged
schema: bug fixes #784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 27, 2017 13:49
Signed-off-by: zhouhao <zhouhao@cn.fujitsu.com>
Signed-off-by: zhouhao <zhouhao@cn.fujitsu.com>
wking
reviewed
Apr 27, 2017
| @@ -32,7 +32,7 @@ | |||
| }, | |||
| "shares": { | |||
| "id": "https://opencontainers.org/schema/bundle/windows/resources/cpu/shares", | |||
| "$ref": "defs-windows.json#/definitions/cpuShares" | |||
| "$ref": "defs.json#/definitions/uint16" | |||
wking
added a commit
to wking/opencontainer-runtime-spec
that referenced
this pull request
Apr 27, 2017
And fill in some known-good and known-bad examples. We can make this as detailed as we want, but this commit just adds enough to know that: * The full-file spec examples are valid. * The JSON Schema can distinguish valid examples from invalid JSON. This will help catch JSON Schema typos like those being addressed by [1]. [1]: opencontainers#784 Signed-off-by: W. Trevor King <wking@tremily.us>
wking
added a commit
to wking/opencontainer-runtime-spec
that referenced
this pull request
Apr 27, 2017
And fill in some known-good and known-bad examples. We can make this as detailed as we want, but this commit just adds enough to know that: * The full-file spec examples are valid. * The JSON Schema can distinguish valid examples from invalid JSON. This will help catch JSON Schema typos like those being addressed by [1]. [1]: opencontainers#784 Signed-off-by: W. Trevor King <wking@tremily.us>
wking
added a commit
to wking/opencontainer-runtime-spec
that referenced
this pull request
Apr 27, 2017
And fill in some known-good and known-bad examples. We can make this as detailed as we want, but this commit just adds enough to know that: * The full-file spec examples are valid. * The JSON Schema can distinguish valid examples from invalid JSON. This will help catch JSON Schema typos like those being addressed by [1]. [1]: opencontainers#784 Signed-off-by: W. Trevor King <wking@tremily.us>
|
LGTM |
1 similar comment
|
LGTM |
wking
added a commit
to wking/opencontainer-runtime-spec
that referenced
this pull request
May 9, 2017
And fill in some known-good and known-bad examples. We can make this as detailed as we want, but this commit just adds enough to know that: * The full-file spec examples are valid. * The JSON Schema can distinguish valid examples from invalid JSON. This will help catch JSON Schema typos like those being addressed by [1]. [1]: opencontainers#784 Signed-off-by: W. Trevor King <wking@tremily.us>
wking
added a commit
to wking/opencontainer-runtime-spec
that referenced
this pull request
May 9, 2017
And fill in some known-good and known-bad examples. We can make this as detailed as we want, but this commit just adds enough to know that: * The full-file spec examples are valid. * The JSON Schema can distinguish valid examples from invalid JSON. This will help catch JSON Schema typos like those being addressed by [1]. [1]: opencontainers#784 Signed-off-by: W. Trevor King <wking@tremily.us>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: zhouhao zhouhao@cn.fujitsu.com