config-linux: Remove explicit 'null' from device cgroup values #804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Catch the Markdown spec up with the JSON Schema change in 0927437 (schema: Drop pointers and nulls, 2017-01-18, opencontainers#662). The Markdown is canonical, so we could restore the explicit-null handling to the JSON Schema instead, but the maintainers feel (and I agree) that there's no point in explicitly allowing a null value when callers can simply leave the property unset [1]. [1]: opencontainers#555 (comment) Signed-off-by: W. Trevor King <wking@tremily.us>
|
LGTM |
1 similar comment
|
LGTM |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Catch the Markdown spec up with the JSON Schema change in #662. The Markdown is canonical, so we could restore the explicit-null handling to the JSON Schema instead, but the maintainers feel (and I agree) that there's no point in explicitly allowing a null value when callers can simply leave the property unset.