Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows: Add IgnoreFlushesDuringBoot #816

Merged
merged 1 commit into from
May 23, 2017

Conversation

lowenna
Copy link
Contributor

@lowenna lowenna commented May 12, 2017

Signed-off-by: John Howard jhoward@microsoft.com

Similar to #814, the Windows implementation of the docker daemon still passes a number of fields out of band from the OCI runtime spec. This PR addresses the IgnoreFlushesDuringBoot field by adding it to the runtime spec. https://github.com/moby/moby/blob/master/libcontainerd/client_windows.go#L156-L159

@lowenna
Copy link
Contributor Author

lowenna commented May 15, 2017

Added field to schema\config-windows.json

@tianon
Copy link
Member

tianon commented May 18, 2017

LGTM

Approved with PullApprove

@mrunalp
Copy link
Contributor

mrunalp commented May 18, 2017

Needs rebase.

Signed-off-by: John Howard <jhoward@microsoft.com>
@lowenna
Copy link
Contributor Author

lowenna commented May 23, 2017

Rebased.

@tianon
Copy link
Member

tianon commented May 23, 2017

LGTM

(redux)

Approved with PullApprove

@TomSweeneyRedHat
Copy link

LGTM

@dqminh
Copy link
Contributor

dqminh commented May 23, 2017

LGTM

Approved with PullApprove

@dqminh dqminh merged commit 4d51b59 into opencontainers:master May 23, 2017
@vbatts vbatts mentioned this pull request Jul 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants