-
Notifications
You must be signed in to change notification settings - Fork 553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
glossary: Remove "leaf" and "hierarchy" from container namespace definition #852
Merged
mrunalp
merged 2 commits into
opencontainers:master
from
wking:cleaner-container-namespace-glossary
Jun 1, 2017
Merged
glossary: Remove "leaf" and "hierarchy" from container namespace definition #852
mrunalp
merged 2 commits into
opencontainers:master
from
wking:cleaner-container-namespace-glossary
Jun 1, 2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nition Namespaces are not all hierarchical and processes aren't always in leaves. Signed-off-by: W. Trevor King <wking@tremily.us>
This was referenced May 24, 2017
Pulled in #853 based on today's meeting. |
glossary.md
Outdated
New container namespaces will be created as children of the runtime namespaces. | ||
|
||
On Linux, the namespaces from which new [container namespaces](#container-namespace) are [created](config-linux.md#namespaces) and from which some configured resources are accessed. | ||
Examples of resources retrieved from this namespace include [`linux.namespaces[].path`](config-linux.md#namespaces) and the [`resctrl` psuedo-filesystem used for `linux.intelRdt`](config-linux.md#intelrdt). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove this line.
mrunalp
reviewed
Jun 1, 2017
glossary.md
Outdated
New container namespaces will be created as children of the runtime namespaces. | ||
|
||
On Linux, the namespaces from which new [container namespaces](#container-namespace) are [created](config-linux.md#namespaces) and from which some configured resources are accessed. | ||
Examples of resources retrieved from this namespace include [`linux.namespaces[].path`](config-linux.md#namespaces) and the [`resctrl` psuedo-filesystem used for `linux.intelRdt`](config-linux.md#intelrdt). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this line.
…tion Namespaces are not all hierarchical and processes aren't always in leaves. Also punt to config-linux.md for details about namespace creation, although currently that section doesn't talk much about how the runtime namespaces relate to new container namespaces [1]. Also mention resource access, because runtime namespaces play a role even if no new container namespaces are created. I've used resources that currently explicitly mention runtime namespaces as examples, although I think more resources (e.g. root.path and mounts[].source [2,3]) deserve wording about that as well and would be better examples if they'd already landed such wording. Examples of resources retrieved from this namespace include linux.namespaces[].path and the resctrl psuedo-filesystem used for `linux.intelRdt`, but Mrunal and Michael didn't want me to include the examples in the glossary entry (probably because they could go stale). [1]: opencontainers#795 (comment) [2]: opencontainers#735 (comment) [3]: opencontainers@604205e#diff-c9c91c29b41257aea3a3403cc606ad99R65 Signed-off-by: W. Trevor King <wking@tremily.us>
wking
force-pushed
the
cleaner-container-namespace-glossary
branch
from
June 1, 2017 17:57
5c50462
to
b536f13
Compare
1 similar comment
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Namespaces are not all hierarchical and processes aren't always in leaves.
Spun off from #795.