config-linux: Explicitly allow symlinks for providing devices #873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'd rather address runtime compliance by breaking this down into explicit checks based on POSIX stat(3) calls. But with that approach rejected [1], mentioning symlinks here helps motivate runtime-tools' choice of os.Stat [2,3] (which follows symlinks) vs. os.Lstat (which does not [4]). [1]: opencontainers#829 (comment) [2]: https://github.com/opencontainers/runtime-tools/blob/f5c82b3918bdfc3ed4b594dcfab4d1554beaf992/cmd/runtimetest/main.go#L319 [3]: https://golang.org/pkg/os/#Stat [4]: https://golang.org/pkg/os/#Lstat Signed-off-by: W. Trevor King <wking@tremily.us>
|
LGTM (although in my opinion, the existing wording already covers this case with "however it likes" and "etc.") |
|
LGTM |
dklyle
approved these changes
Jun 21, 2017
wking
added a commit
to wking/opencontainer-runtime-spec
that referenced
this pull request
Jun 21, 2017
Through fd0b0b6 (Merge pull request opencontainers#873 from wking/symlinks-for-devices, 2017-06-21). Signed-off-by: W. Trevor King <wking@tremily.us>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd rather address runtime compliance by breaking this down into explicit checks based on POSIX stat(3) calls. But with that approach rejected, mentioning symlinks here helps motivate runtime-tools' choice of
os.Stat(which follows symlinks) vs.os.Lstat(which does not).Spun off as a non-controversial portion of the rejected #829, as requested by @crosbymichael on 2017-06-01 (although that request didn't make it into the log).